[ https://issues.apache.org/jira/browse/CB-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Silveira resolved CB-5796. ---------------------------------- Resolution: Fixed Fix Version/s: Master Fixed by this [commit|https://github.com/mozilla-cordova/cordova-plugin-network-information/commit/1fa3ae6e47ab26c11e69721807a8ea42d8723f81]. > Firefox OS Network Information doesn't work > ------------------------------------------- > > Key: CB-5796 > URL: https://issues.apache.org/jira/browse/CB-5796 > Project: Apache Cordova > Issue Type: Bug > Components: FirefoxOS, Plugin Network Information > Affects Versions: 3.3.0 > Reporter: Nam Kim > Assignee: Rodrigo Silveira > Fix For: Master > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > h4. Issue #1: > {code:javascript|title=cordova-plugin-network-information/src/firefoxos/NetworkProxy.js:ln32} > var connection = navigator.connection || navigator.mozConnection || > navigator.webkitConnection; > {code} > The line above is written inside an object declaration, which causes syntax > errors. > h4. Issue #2 > navigator.connection exists, but connection.bandwidth and connection.metered > are undefined. We should instead be checking for mozConnection.bandwidth and > mozConnection.metered. > Suggested fix: > {code:javascript} > var connection = navigator.mozConnection || navigator.webkitConnection; > {code} > h4. Issue #3 > {code:javascript|title=cordova-plugin-network-information/src/firefoxos/NetworkProxy.js:ln60} > require("cordova/firefoxos/commandProxy").add("Network", module.exports);}); > {code} > should be > {code:javascript} > require("cordova/firefoxos/commandProxy").add("NetworkStatus", > module.exports);}); > {code} > h4. Issue #4 > The overridden navigator.connection.type doesn't speak Cordova interface. > I am not too familiar with Firefox OS, but just wondering if > navigator.mozConnection.bandwidth is 0, it can be translated to "none" and > else (if bandwidth is not 0) "unknown". -- This message was sent by Atlassian JIRA (v6.2#6252)