[
https://issues.apache.org/jira/browse/CB-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017927#comment-14017927
]
ASF GitHub Bot commented on CB-6396:
------------------------------------
Github user zalun commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/47#discussion_r13400172
--- Diff: src/firefoxos/InAppBrowserProxy.js ---
@@ -47,10 +47,34 @@ var IABExecs = {
open: function (win, lose, args) {
var strUrl = args[0],
target = args[1],
- features = args[2],
+ features_string = args[2],
+ features = {},
url,
elem;
+ var features_list = features_string.split(',');
+ features_list.forEach(function(feature) {
+ var tup = feature.split('=');
+ if (tup[1] == 'yes') {
+ tup[1] = true;
+ } else if (tup[1] == 'no') {
+ tup[1] = false;
+ } else {
+ var number = parseInt(tup[1]);
+ if (!isNaN(number)) {
+ tup[1] = number;
+ }
+ }
+ features[tup[0]] = tup[1];
+ });
+
+ function updateIframeSizeNoLocation() {
+ browserWrap.style.width = window.innerWidth + 'px';
+ browserWrap.style.height = window.innerHeight + 'px';
+ browserWrap.browser.style.height = (window.innerHeight - 60) +
'px';
--- End diff --
Yes
> inappbrowser
> ------------
>
> Key: CB-6396
> URL: https://issues.apache.org/jira/browse/CB-6396
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Plugin InAppBrowser
> Affects Versions: 3.6.0
> Reporter: Piotr Zalewa
> Assignee: Piotr Zalewa
>
> Add InAppBrowser for firefoxos
--
This message was sent by Atlassian JIRA
(v6.2#6252)
