[
https://issues.apache.org/jira/browse/CB-6932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029526#comment-14029526
]
ASF GitHub Bot commented on CB-6932:
------------------------------------
Github user axemclion commented on a diff in the pull request:
https://github.com/apache/cordova-wp8/pull/40#discussion_r13716495
--- Diff: wp8/bin/create.js ---
@@ -71,16 +71,42 @@ function read(filename) {
return s;
}
+// Reads content of utf-8 encoded file, removing BOM, if exist.
+function readUTF8 (filename) {
--- End diff --
Can this be renamed as read, since this is doing read anyway.
> Cannot build wp8 under Chinese (Simplified) System locale
> ---------------------------------------------------------
>
> Key: CB-6932
> URL: https://issues.apache.org/jira/browse/CB-6932
> Project: Apache Cordova
> Issue Type: Bug
> Components: WP8
> Affects Versions: 3.6.0
> Environment: Windows 8.1, Simlified Chinese locale
> Reporter: Vladimir Kotikov
> Assignee: Jesse MacFadyen
> Labels: chinese, locale, wp8
> Fix For: 3.6.0
>
>
> *Steps to reproduce:*
> # Set Region > Administrative > Change System Locale to Chinese (Simplified,
> China).
> # Restart machine.
> # cordova create hello
> # cd hello
> # cordova platform add wp8
> # cordova build wp8
> Error appears.
> {noformat}
> D:\PROJECTS\Temp\test-bom\platforms\wp8\App.xaml(1,1,1,1): error : Invalid
> character in the given encoding. Line 1, position 1.
> [D:\PROJECTS\Temp\test-bom\platforms\wp8\HelloCordova.csproj]
> {noformat}
> There is a malformed files that changed during create process for the wp8
> project under the Chinese system locale. It looks like create.js is
> interpreting the initial file header incorrectly with the Chinese system
> locale, then printing it out to the file.
> Build will fail under a different System locale as well.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
