[ 
https://issues.apache.org/jira/browse/CB-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046377#comment-14046377
 ] 

ASF subversion and git services commented on CB-7045:
-----------------------------------------------------

Commit 56276ef3e4d407bdd9c1212f5d75b267ede0530d in cordova-lib's branch 
refs/heads/master from [~jsoref]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=56276ef ]

CB-7045 plugman.install: engine.currentVersion should be a semver or null

not ""


> improve plugman install (+spec)
> -------------------------------
>
>                 Key: CB-7045
>                 URL: https://issues.apache.org/jira/browse/CB-7045
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugman
>    Affects Versions: 3.5.0
>            Reporter: Josh Soref
>            Assignee: Josh Soref
>             Fix For: 3.6.0
>
>
> Currently install.spec skips some of its tests, i'd like more of them to work.
> {quote}
> function checkEngines(engines) {
> ...
>         if ( semver.satisfies(engine.currentVersion, engine.minVersion) || 
> engine.currentVersion === null ) {
> {quote}
> this expects currentVersion to be a *number* or {{null}}, but currently it's 
> possible for it to be {{""}}
> {{cleanVersionOutput}} will take {{""}} and return {{""}} which isn't 
> helpful...
> {{callEngineScripts}} calls {{child_process.exec(scriptPath...}} and handles 
> error, but not no output.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to