[
https://issues.apache.org/jira/browse/CB-7190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078177#comment-14078177
]
ASF GitHub Bot commented on CB-7190:
------------------------------------
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/66#discussion_r15544876
--- Diff: cordova-lib/src/plugman/plugman.js ---
@@ -70,6 +70,7 @@ addProperty(plugman, 'install', './install', true);
addProperty(plugman, 'uninstall', './uninstall', true);
addProperty(plugman, 'fetch', './fetch', true);
addProperty(plugman, 'prepare', './prepare');
+addProperty(plugman, 'prepareBrowserify', './prepare-browserify');
--- End diff --
Isn't this already taken care of here:
https://github.com/surajpindoria/cordova-lib/blob/browserify/cordova-lib/src/plugman/plugman.js#L131
the browserify and non-browserify methods have the exact same signature, so
we should be calling a generic 'prepare' method which could be either one.
> Add browserify support in cordova-lib/cordova-cli
> -------------------------------------------------
>
> Key: CB-7190
> URL: https://issues.apache.org/jira/browse/CB-7190
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Affects Versions: 3.5.0
> Reporter: Anis Kadri
> Assignee: Suraj Pindoria
> Fix For: 3.8.0
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
