[ 
https://issues.apache.org/jira/browse/CB-7129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090901#comment-14090901
 ] 

ASF GitHub Bot commented on CB-7129:
------------------------------------

Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-windows/pull/38#issuecomment-51620450
  
    Jesse, please let me know your consideration regarding promises usage and 
if there are places which should be improved. I personally tried to do my best 
to make code as readable as possible, but it's not so easy taking into account 
async nature of shell commands. I see, there is the same situation on Android 
where there are many async methods. 
    
https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/run.js#L95
    Promises helps here a lot since we don't need to manually manage 
success/error callbacks/cases and can chain them.


> Switch to nodejs for windows platform scripts
> ---------------------------------------------
>
>                 Key: CB-7129
>                 URL: https://issues.apache.org/jira/browse/CB-7129
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Windows 8
>    Affects Versions: 3.6.0
>            Reporter: Vladimir Kotikov
>            Assignee: Jesse MacFadyen
>             Fix For: 3.6.0
>
>
> Current realization of platform/tooling scripts on Windows is using WSH 
> (Windows Scripting Host) as JS engine which works unpredictable with unicode 
> symbols (incorrect reading/writing of UTF-8 encoded files, incorect passing 
> of unicode paths as arguments to another scripts, etc.) 
> Switching to NodeJS can help to resolve many of unicode related issues in 
> cordova-windows projects.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to