[ 
https://issues.apache.org/jira/browse/CB-7332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102603#comment-14102603
 ] 

ASF GitHub Bot commented on CB-7332:
------------------------------------

Github user surajpindoria commented on a diff in the pull request:

    https://github.com/apache/cordova-js/pull/77#discussion_r16433602
  
    --- Diff: tasks/lib/require-tr.js ---
    @@ -86,7 +88,15 @@ function _updateRequires(code) {
         if(node instanceof UglifyJS.AST_Call) {
           // check if function call is a require('module') call
           if(node.expression.name === "require" && node.args.length === 1) {
    +
    +        // Uglify is not able to recognize Windows style paths using '\' 
instead of '/'
    +        // So replacing all of the '/' back to Windows '\'
    +        if (node.args[0].value !== undefined && 
node.args[0].value.indexOf('/android/app') !== -1 && process.platform === 
'win32') {
    --- End diff --
    
    I have added the check for the Windows platform now.  I also removed the 
check for 'c:' and changed it to check for '/android/app'.  We need this here 
because in the code above, we are actually replacing code in the source file, 
so it needs to be changed back to appropriate Windows path.
    @purplecabbage 


> Module cordova/plugin/<platform>/app does not exist when packaging plugins 
> using browserify on Windows
> ------------------------------------------------------------------------------------------------------
>
>                 Key: CB-7332
>                 URL: https://issues.apache.org/jira/browse/CB-7332
>             Project: Apache Cordova
>          Issue Type: Bug
>            Reporter: Suraj Pindoria
>            Assignee: Suraj Pindoria
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to