[ https://issues.apache.org/jira/browse/CB-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170096#comment-14170096 ]
ASF subversion and git services commented on CB-2520: ----------------------------------------------------- Commit 78ca06e1ae14ad895d73ac5d141843cc94ecae33 in cordova-ios's branch refs/heads/master from [~khawk...@salesforce.com] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=78ca06e ] CB-2520 - iOS - "original" user agent needs to be overridable (closes #112) Signed-off-by: Shazron Abdullah <shaz...@apache.org> > iOS: "original" user agent needs to be overridable > -------------------------------------------------- > > Key: CB-2520 > URL: https://issues.apache.org/jira/browse/CB-2520 > Project: Apache Cordova > Issue Type: New Feature > Components: iOS > Affects Versions: Master > Reporter: Kevin Hawkins > Assignee: Shazron Abdullah > Labels: core > Fix For: 3.5.0 > > Original Estimate: 8h > Remaining Estimate: 8h > > Cordova's user agent management for iOS employs a scheme of setting a > baseline "original" user agent, which by default conforms to the standard > user agent a UIWebView would expose, and then optionally appending > CDVViewController-specific data to it in the appropriate use cases, to manage > whitelisting. > Cordova shouldn't really care too much about the data that the original user > agent exposes. I.e. it should be able to be overridden by a consumer, so > that the consumer can supply its own user agent data. This is not > technically possible with the current implementation of the CDVUserAgentUtil > class, since it does not exist as a member of any instance class; it's truly > static/global, so inheritance doesn't come into play. > Even if an instance of CDVuserAgentUtil could be made a property of > CDVViewController, or something else, it would be kind of weird for a > consumer to inherit from what's essentially a static class, just to configure > their own user agent data. > There should be another mechanism for users to override the original user > agent configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org