[
https://issues.apache.org/jira/browse/CB-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219653#comment-14219653
]
ASF GitHub Bot commented on CB-6472:
------------------------------------
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/115#issuecomment-63848626
Looks good overall. 2 style notes, both are optional, tell me if you prefer
not to change it:
1) Would be great if you could run jscs with the default config in
cordova-lib/.jscs.json, it's not set in stone and you are welcome to contribute
to the discussion of what this configuration should look like. But it really
helps with obvious things like trailing spaces etc. that jshint stopped
checking for in the latest versions.
2) underscore usage as "_" turns out to be a bit problematic in node.js
during debugging because node interactive interpreter uses _ to keep the last
printed result. There seem to be no other dominant conventions, but double
underscore "__" is a popular choice.
> Adding content to -Info.plist - Unexpected behaviour
> ----------------------------------------------------
>
> Key: CB-6472
> URL: https://issues.apache.org/jira/browse/CB-6472
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugman
> Affects Versions: 3.4.0
> Environment: Mac OS X
> Reporter: Jean-Christophe Hoelt
> Priority: Minor
>
> Trying to add content NOT at the root of info.plist, to a node already having
> existing content.
> The existing content gets deleted, not merged with new content.
> Use case: a plugin providing Newsstand integration.
> Doing this in plugin.xml:
> {code}
> <config-file target="*-Info.plist" parent="CFBundleIcons">
> <dict>
> <key>CFBundlePrimaryIcon</key>
> <dict>
> <key>UINewsstandIcon</key>
> <dict>
> ...
> {code}
> Info.plist before install:
> {code}
> <key>CFBundleIcons</key>
> <dict>
> <key>CFBundlePrimaryIcon</key>
> <dict>
> <key>CFBundleIconFiles</key>
> <array>
> ...
> </array>
> </dict>
> </dict>
> {code}
> Info.plist after install:
> {code}
> <key>CFBundleIcons</key>
> <dict>
> <key>CFBundlePrimaryIcon</key>
> <dict>
> <key>UINewsstandIcon</key>
> <dict>
> ...
> </dict>
> </dict>
> </dict>
> {code}
> Info.plist expected:
> {code}
> <key>CFBundleIcons</key>
> <dict>
> <key>CFBundlePrimaryIcon</key>
> <dict>
> <key>UINewsstandIcon</key>
> <dict>
> ...
> </dict>
> <key>CFBundleIconFiles</key>
> <array>
> ...
> </array>
> </dict>
> </dict>
> {code}
> If this is not unexpected behaviour, then I'd make this issue a feature
> request: adding an option like "merge=true".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
