[ 
https://issues.apache.org/jira/browse/CB-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243162#comment-14243162
 ] 

ASF GitHub Bot commented on CB-8032:
------------------------------------

GitHub user shazron opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/96

    CB-8032 - File Plugin - Add nativeURL external method support for 
CDVFileSystem->makeEntryForPath:isDirectory:

    - backwards compatible
    - if urlTransformer is not set, it will return the passed in NSURL

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-plugin-file CB-8032-

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/96.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #96
    
----
commit 93b17a4c7f674269922f5511104dd60cddcd1461
Author: Shazron Abdullah <shaz...@apache.org>
Date:   2014-12-11T21:03:34Z

    CB-8032 - File Plugin - Add nativeURL external method support for 
CDVFileSystem->makeEntryForPath:isDirectory:

----


> Add nativeURL external method support for 
> CDVFileSystem->makeEntryForPath:isDirectory:
> --------------------------------------------------------------------------------------
>
>                 Key: CB-8032
>                 URL: https://issues.apache.org/jira/browse/CB-8032
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Plugin Camera, Plugin Contacts, Plugin File, Plugin File 
> Transfer, Plugin Media, Plugin Media Capture
>         Environment: iOS
>            Reporter: Shazron Abdullah
>
> Right now in CDVFileSystem->makeEntryForPath:isDirectory:, in the 
> NSDictionary that is returned, for the key "nativeURL" the format is fixed 
> (file:// protocol for a local filesystem reference, and assets-library:/ for 
> a assets library filesystem reference.)
> When calculating the nativeURL, allow this to be specified externally, check 
> for a selector "nativeURL" and call that if available.
> This is for example declared in a Category in this plugin: 
> https://github.com/apache/cordova-plugins/blob/5d8ef21dcbde1f99d60e1b52ae3a3800e4c185d9/local-webserver/src/ios/CDVLocalFileSystem%2BNativeURL.m
> ... which when linked will have the selector available for the File plugin to 
> call.
> This code is part of the local webserver plugin - and it needs the File 
> references to be proxied through a local webserver.
> For example if the FileEntry is to:
>     
>     file://my/package/folder/Documents/foo.txt
> .. the nativeURL would be, with this new category method, and the local 
> webserver listening to http://localhost:8080:
>     http://localhost:8080/local-filesystem/my/package/folder/Documents/foo.txt



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to