[
https://issues.apache.org/jira/browse/CB-8210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271724#comment-14271724
]
ASF GitHub Bot commented on CB-8210:
------------------------------------
GitHub user jpchase opened a pull request:
https://github.com/apache/cordova-js/pull/99
CB-8210 Remove unused onDestroy channel
- Channel was defined as internal event and fired by javascript eval()
- Rather than change firing of event, simpler to remove as was not used
Related to apache/cordova-android#146
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpchase/cordova-js CB8210-remove-ondestroy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-js/pull/99.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #99
----
commit ebf5d997cc6fddcbafb044198b396beb0e9408d4
Author: Jason Chase <jasonpch...@gmail.com>
Date: 2015-01-09T18:53:46Z
CB-8210 Remove unused onDestroy channel
- Channel was defined as internal event and fired by javascript eval()
- Rather than change firing of event, simpler to remove as was not used
----
> Prep cordova-android for CSP by removing eval()s
> ------------------------------------------------
>
> Key: CB-8210
> URL: https://issues.apache.org/jira/browse/CB-8210
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Android
> Affects Versions: Master
> Reporter: Jason Chase
> Assignee: Andrew Grieve
>
> In preparation for CSP, remove any native code in cordova-android is that
> using inline javascript/eval()s.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
