[ 
https://issues.apache.org/jira/browse/CB-8168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275482#comment-14275482
 ] 

ASF GitHub Bot commented on CB-8168:
------------------------------------

Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/145#discussion_r22873213
  
    --- Diff: cordova-lib/src/cordova/targets.js ---
    @@ -0,0 +1,65 @@
    +/**
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +*/
    +
    +var cordova_util = require('./util'),
    +    Q = require('q'),
    +    superspawn = require('./superspawn'),
    +    path = require('path');
    +
    +function handleError(error) {
    +    if (error.code === 'ENOENT') {
    +        console.log('Platform not supported');
    --- End diff --
    
    You should use the events.emit function rather than console.log'ing things.


> Listing available devices through the CLI
> -----------------------------------------
>
>                 Key: CB-8168
>                 URL: https://issues.apache.org/jira/browse/CB-8168
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android, CLI, iOS, Windows, Windows 8
>            Reporter: Murat Sutunc
>            Assignee: Jesse MacFadyen
>
> I was looking at the Cordova Tooling Wiki at 
> (https://wiki.apache.org/cordova/CommandLineToolingDesign) and thought it 
> would be interesting to make some additions to the list-devices feature. 
> Currently we have list-devices and list-emulator-images scripts for a lot of 
> different platforms. However these scripts are not easily accessible from the 
> Cordova CLI. By introducing an additional argument to the run or emulate 
> command, we could show a list of available emulators or connected devices. (I 
> would like to deemphasize the fact that the command is called --list). After 
> invoking the command, a user can decide which target to use and run the app 
> on the desired target by using cordova run –device devicename



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to