[ 
https://issues.apache.org/jira/browse/CB-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14285861#comment-14285861
 ] 

ASF subversion and git services commented on CB-8270:
-----------------------------------------------------

Commit bfff56aef43ff36b4551f04d1585b1512c506713 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~agrieve]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=bfff56a
 ]

CB-8270 Remove usage of `[arr JSONString]`, since it's been renamed to 
`cdv_JSONString`

Just updating to the new name would make the plugin incompatible with
previous cordova-ios versions.


> Objective-C methods on categories should be named with a prefix
> ---------------------------------------------------------------
>
>                 Key: CB-8270
>                 URL: https://issues.apache.org/jira/browse/CB-8270
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: iOS
>    Affects Versions: Master
>         Environment: All iOS platforms
>            Reporter: Ruoyu Fu
>            Priority: Critical
>              Labels: categories, ios, namespace
>             Fix For: Master
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> According to Apple's documentation, naming a Category method without a prefix 
> would possibly cause a Name Clash
> https://developer.apple.com/library/ios/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/CustomizingExistingClasses/CustomizingExistingClasses.html#//apple_ref/doc/uid/TP40011210-CH6-SW4
> In CordovaLib/Classes/CDVJSON.h : NSArray(CDVJSONSerializing) 
> The method name should starts with a prefix



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to