[ https://issues.apache.org/jira/browse/CB-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294744#comment-14294744 ]
ASF GitHub Bot commented on CB-5059: ------------------------------------ GitHub user dpogue opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/60 CB-5059 Add a CookieManager abstraction for pluggable webviews. This allows FileTransfer to correctly use webview cookies regardless of which webview engine is in use. /cc @agrieve @infil00p Requires apache/cordova-android#151 Refs #8 Refs MobileChromeApps/mobile-chrome-apps#464 Refs MobileChromeApps/cordova-crosswalk-engine#16 Refs crosswalk-project/crosswalk-cordova-android#38 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dpogue/cordova-plugin-file-transfer 4.0.x-cookies Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file-transfer/pull/60.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #60 ---- commit 7fa40760b69586f06267c1036f36a4d3db22488a Author: Darryl Pogue <dvpdin...@gmail.com> Date: 2015-01-28T05:14:45Z CB-5059 Add a CookieManager abstraction for pluggable webviews. This allows FileTransfer to correctly use webview cookies regardless of which webview engine is in use. ---- > The android implementation of file transfer plugin should not depend on the > concrete class android.webkit.CookieManager > ----------------------------------------------------------------------------------------------------------------------- > > Key: CB-5059 > URL: https://issues.apache.org/jira/browse/CB-5059 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin File Transfer > Affects Versions: Master > Environment: cordova-android, git branch 3.0.x > Reporter: Junmin > Fix For: Master > > > The android implementation of file transfer plugin leverages the class > android.webkit.CookieManager, which depends on the concrete web > infrastructure android.webkit.WebView. This dependence ruins the portability > of the plugin. For example, it could not run on a substantial implementation > of CordovaWebView which based on a android third party component(such as > chromium for android). > Following is the crash log when initializing the CookieManager without > android.webkit.WebView: > I/dalvikvm(5006): java.lang.IllegalStateException: Call > CookieSyncManager::createInstance() or create a webview before using this > class > I/dalvikvm(5006): at > android.webkit.JniUtil.checkInitialized(JniUtil.java:44) > I/dalvikvm(5006): at > android.webkit.JniUtil.getDatabaseDirectory(JniUtil.java:65) > I/dalvikvm(5006): at > android.webkit.CookieManagerClassic.nativeGetCookie(Native Method) > I/dalvikvm(5006): at > android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:109) > I/dalvikvm(5006): at > android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:96) > I/dalvikvm(5006): at > org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:747) -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org