[
https://issues.apache.org/jira/browse/CB-7567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14326496#comment-14326496
]
ASF GitHub Bot commented on CB-7567:
------------------------------------
GitHub user jbuck opened a pull request:
https://github.com/apache/cordova-firefoxos/pull/22
CB-7567 Don't use adm-zip because it creates invalid zip files
This patch is a fix for
[CB-7567](https://issues.apache.org/jira/browse/CB-7567) where the current
build step using [adm-zip creates invalid zip
files](https://github.com/cthackers/adm-zip/issues/71). I switched to archiver
because that's what our projects after_build script use, and what
[cordova-browser uses](https://github.com/apache/cordova-browser/pull/10).
@stevengill I haven't contributed to Apache Cordova before. I know I need
to sign the CLA. Is there anything else I need to do from a contribution
standpoint?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbuck/cordova-firefoxos fix-zip
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-firefoxos/pull/22.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22
----
commit bd21ce3b06db8ee6315c6ad591eef2f18265c037
Author: Jon Buckley <[email protected]>
Date: 2015-02-18T16:13:43Z
CB-7567 Don't use adm-zip because it creates invalid zip files
----
> firefox os build compression corrupted certain JPEG files
> ---------------------------------------------------------
>
> Key: CB-7567
> URL: https://issues.apache.org/jira/browse/CB-7567
> Project: Apache Cordova
> Issue Type: Bug
> Components: FirefoxOS
> Affects Versions: 3.5.0
> Environment: Cordova 3.5.0-0.2.7, Ionic 1.2.5, Ubuntu 14.04 64-bit
> Reporter: Hendy Irawan
> Attachments: Vegetable-Pasta.jpg
>
>
> Some image files cannot be compressed properly by {{build firefoxos}}.
> However, during build there is no error.
> During extraction, these affected files will have 0 byte size.
> For example, unzipping the package.zip will emit following error message:
> {code}
> inflating: recipe_photos/Vegetable-Pasta.jpg
> error: invalid compressed data to inflate
> creating: templates/
> {code}
> Example file that cannot be compressed is attached.
> Note that the file is correct in
> {{platforms/firefoxos/www/recipe_photos/Vegetable-Pasta.jpg}}. It's only
> corrupted inside the ZIP file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
