[
https://issues.apache.org/jira/browse/CB-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333604#comment-14333604
]
ASF GitHub Bot commented on CB-7827:
------------------------------------
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/171#discussion_r25186284
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg,
template_dir, opts) {
if (/android|ios/.exec(platDetails.platform) &&
semver.gt(platDetails.version, '3.3.0')) {
args.push('--cli');
}
-
+
var pkg = cfg.packageName().replace(/[^\w.]/g,'_');
// CB-6992 it is necessary to normalize characters
// because node and shell scripts handles unicode symbols differently
// We need to normalize the name to NFD form since iOS uses NFD
unicode form
var name = platDetails.platform == 'ios' ? unorm.nfd(cfg.name()) :
cfg.name();
args.push(output, pkg, name);
+
+ var activityName = cfg.android_activityName();
+ if (activityName && platDetails.platform === 'android') {
+ activityName = activityName.replace(/W/g, '');
+ args.push(activityName);
--- End diff --
We need this to continue to work for older versions of cordova-android. You
should add this arg only if:
semver.gte(platDetails.version, '4.0.0-dev')
> manifest/application/activity[android:name] always CordovaApp
> -------------------------------------------------------------
>
> Key: CB-7827
> URL: https://issues.apache.org/jira/browse/CB-7827
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
> Affects Versions: 4.0.0
> Environment: Windows 8.1 x64, NodeJs 0.10.32
> Reporter: Sergey
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
