[ https://issues.apache.org/jira/browse/CB-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336820#comment-14336820 ]
ASF GitHub Bot commented on CB-8537: ------------------------------------ GitHub user rob-close opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/56 CB-8537 Updated source to pass Fortify scan. Made changes for the following issues: From Fortify: Poor Error Handling: Empty Catch Block (Errors, Structural) And from SonarQube: Implicitly using the default locale is a common source of bugs: Use toLowerCase(Locale) instead You can merge this pull request into a Git repository by running: $ git pull https://github.com/rob-close/cordova-plugin-contacts CB-8537 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/56.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #56 ---- commit f8b6fb89f619297be3f536d39a9435cf66289ce4 Author: Rob Close <rob-close> Date: 2015-02-25T17:32:34Z CB-8537 Updated source to pass Fortify scan. Made changes for the following issues: From Fortify: Poor Error Handling: Empty Catch Block (Errors, Structural) And from SonarQube: Implicitly using the default locale is a common source of bugs: Use toLowerCase(Locale) instead ---- > Contacts plugin Android source does not pass Fortify scan > --------------------------------------------------------- > > Key: CB-8537 > URL: https://issues.apache.org/jira/browse/CB-8537 > Project: Apache Cordova > Issue Type: Bug > Components: Android > Affects Versions: Master > Environment: Android > Reporter: Rob Close > Priority: Minor > Fix For: Master > > > Modify the code to remove the following warnings > From Fortify: > Poor Error Handling: Empty Catch Block (Errors, Structural) > And from SonarQube: > Implicitly using the default locale is a common source of bugs: Use > toLowerCase(Locale) instead -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org