[ 
https://issues.apache.org/jira/browse/CB-8596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355399#comment-14355399
 ] 

ASF GitHub Bot commented on CB-8596:
------------------------------------

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/177#discussion_r26150341
  
    --- Diff: cordova-lib/spec-cordova/project-metadata-apis.spec.js ---
    @@ -0,0 +1,85 @@
    +/**
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +*/
    +
    +var cordova = require('../src/cordova/cordova'),
    +    helpers = require('./helpers'),
    +    shell   = require('shelljs'),
    +    path    = require('path');
    +
    +describe('retrieval of project metadata', function(){
    +
    +    var appId = 'org.testing';
    +    var appName = 'ProjectMetadataRetrievalTests';
    +
    +    var configNormal = {
    +        lib: {
    +            www: {
    +                url: path.join(__dirname, 'fixtures', 'base', 'www'),
    +                version: 'testProjectMetadataRetrieval',
    +                id: appName
    +            }
    +        }
    +    };
    +
    +    var tmpDir = helpers.tmpDir('project_metadata_test');
    +    var projectRoot = path.join(tmpDir, appName);
    +
    +    beforeEach(function(){
    +        shell.rm('-rf', tmpDir);
    +        shell.rm('-rf', projectRoot);
    +        shell.mkdir('-p', tmpDir);
    +    });
    +
    +    afterEach(function() {
    +        process.chdir(path.join(__dirname, '..'));  // Windows: Needed to 
rm the dir on Windows.
    +        shell.rm('-rf', tmpDir);
    +    });
    +    
    +    it('retrieve platforms and plugins saved in config.xml', 
function(done){
    +        var devicePlugin = 'org.apache.cordova.device@0.2.11'; 
    --- End diff --
    
    Wonder if you need to add test case for git url being specified?


> cordova-lib API for retrieval of platforms and plugins from config.xml 
> -----------------------------------------------------------------------
>
>                 Key: CB-8596
>                 URL: https://issues.apache.org/jira/browse/CB-8596
>             Project: Apache Cordova
>          Issue Type: New Feature
>            Reporter: Omar Mefire
>            Assignee: Omar Mefire
>
> IDE's and other apps using cordova's APIs need a way to access project's 
> metadata (platforms and plugins within config.xml) without going directly 
> through the ConfigParser. They should be abstracted away from the storage 
> details.
> This modification is made even more important with the upcoming move to npm 
> that is going to necessitate moving platforms and plugins infos to 
> package.json.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to