[ https://issues.apache.org/jira/browse/CB-8554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14365509#comment-14365509 ]
ASF GitHub Bot commented on CB-8554: ------------------------------------ Github user agrieve commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/102#issuecomment-82477043 Changes look good I think, but I've sadly landed some code before looking at this that causes it to not merge cleanly. Would you be able to rebase? > File plugin Android source does not pass Fortify scan > ----------------------------------------------------- > > Key: CB-8554 > URL: https://issues.apache.org/jira/browse/CB-8554 > Project: Apache Cordova > Issue Type: Bug > Components: Android > Affects Versions: Master > Environment: Android > Modify the code to remove the following warnings > From Fortify: > Access Control: SecurityManager Bypass (Security Features, Structural) > Poor Error Handling: Empty Catch Block (Errors, Structural) > Poor Style: Non-final Public Static Field (Encapsulation, Structural) > Poor Error Handling: Throw Inside Finally (Errors, Structural) > And from SonarQube: > Preserve Stack Trace > Reliance on default encoding > Reporter: Rob Close > Priority: Minor > Fix For: Master > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org