[ https://issues.apache.org/jira/browse/CB-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372174#comment-14372174 ]
ASF GitHub Bot commented on CB-8728: ------------------------------------ GitHub user vldmrrr opened a pull request: https://github.com/apache/cordova-plugin-file/pull/106 CB-8728 fix write after seek on windows write operation of FileWriter overwrites completely contents of existing file after write position was set by seek function. Automated tests for plugin only verify the length of writer object, but do not check the actual data written to file. Changes included for code and tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vldmrrr/cordova-plugin-file CB-8728 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/106.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #106 ---- commit ad64f0e03e33c6cf96d732f4b6dd0f8ba14d375b Author: unknown <vldm...@gmail.com> Date: 2015-03-20T21:36:04Z Use position set by seek when writing data. commit 5c60410791873261065690123eab1a462d8271c6 Author: unknown <vldm...@gmail.com> Date: 2015-03-20T21:36:44Z Verify data in tests for write after seek. ---- > Plugin File on Windows ignores write position set by seek function > ------------------------------------------------------------------ > > Key: CB-8728 > URL: https://issues.apache.org/jira/browse/CB-8728 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File > Affects Versions: Master > Environment: platfrom windows > Reporter: Vladimir Avdonin > > write operation of FileWriter overwrites completely contents of existing file > after write position was set by seek function. Automated tests for plugin > only verify the length of writer object, but do not check the actual data > written to file. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org