[
https://issues.apache.org/jira/browse/CB-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14374805#comment-14374805
]
ASF GitHub Bot commented on CB-8727:
------------------------------------
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/124
CB-8727 Fix failing WebSQL test on Android 5.1
- scrollByLines is an unknown function in Android 5.1
- removed because it causes the exception and does not affect the test
itself
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ktop/cordova-mobile-spec master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-mobile-spec/pull/124.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #124
----
commit 921c2c0c15c1a1a04ceb85949fdb0bf950992714
Author: Karen Tran <ktop...@gmail.com>
Date: 2015-03-22T04:19:06Z
CB-8727 Fix failing WebSQL test on Android 5.1
commit 49f7c962debb0da874521c5ee410b17d02fa9694
Author: Karen Tran <ktop...@gmail.com>
Date: 2015-03-22T04:19:06Z
CB-8727 Fix failing WebSQL test on Android 5.1
- scrollByLines is an unknown funtion in Android 5.1
- removed because it causes the exception and does not affect the test
itself
commit 9edf897f9a533f09b742b15660ba264ff96a0b97
Author: Karen Tran <ktop...@gmail.com>
Date: 2015-03-22T04:52:57Z
Merge branch 'master' of https://github.com/ktop/cordova-mobile-spec
----
> WebSQL test fail on Android 5.1
> -------------------------------
>
> Key: CB-8727
> URL: https://issues.apache.org/jira/browse/CB-8727
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, mobile-spec
> Affects Versions: Master, 3.2.0
> Environment: Android 5.1
> Reporter: Karen Tran
> Priority: Minor
> Labels: android5.1, mobilespec, scrollByLines, websql
> Fix For: Master
>
>
> Regression testing Android 5.1 on mobile-spec.
> WebSQL test fails immediately when trying to create a table.
> Gets exception at line with the scrollByLines() method
> {quote}
> var databaseOutput = function(s) \{
> var el = document.getElementById("database_results");
> el.innerHTML = el.innerHTML + s + "<br>";
> el.scrollByLines(20000);
> \};
> {quote}
> To Fix: Just remove that line. scollByLines() doesn't affect the webSQL test
> so can be removed.
> My guess for why it breaks in Android 5.1 is that it is deprecated, though
> just speculating after looking around for answers.
> Some sources regarding the fix:
> -
> https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/KYJoVzmi_tw/OsTpm27Ty9YJ
> - https://crosswalk-project.org/jira/browse/XWALK-2502
> The earliest version of cordova this line is present in is 3.2.0 and goes all
> the way through Master. And somewhere along the way, index.html starts to
> reference index.js where this line was moved to.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
