[ https://issues.apache.org/jira/browse/CB-8750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382405#comment-14382405 ]
ASF GitHub Bot commented on CB-8750: ------------------------------------ GitHub user dpolivy opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/41 CB-8750 [wp8]: Allow resolution-specific splashscreen images There are two aspect ratios for Windows Phone devices: 15:9 and 16:9. At the moment, though, there is only one splash screen by default for WP8 Cordova apps. When stretched to fit all possible resolutions, this can sometimes look bad. WP supports resolution-specific splashscreens, so this commit adds the same support to the splashscreen plugin. It uses the same base name for the splashscreen, but adds modifiers such as ".screen-<res>" based on the device. If a screen-specific image is found, it is used. If not, we fall back to the single default image. Fixes https://issues.apache.org/jira/browse/CB-8750 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dpolivy/cordova-plugin-splashscreen CB8750 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/41.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #41 ---- commit 542cf56240ae19592bdba2ee67b61a0325eadd00 Author: Dan Polivy <d...@cellartracker.com> Date: 2015-03-26T18:29:50Z CB-8750 [wp8]: Allow resolution-specific splashscreen images There are two aspect ratios for Windows Phone devices: 15:9 and 16:9. At the moment, though, there is only one splash screen by default for WP8 Cordova apps. When stretched to fit all possible resolutions, this can sometimes look bad. WP supports resolution-specific splashscreens, so this commit adds the same support to the splashscreen plugin. It uses the same base name for the splashscreen, but adds modifiers such as ".screen-<res>" based on the device. If a screen-specific image is found, it is used. If not, we fall back to the single default image. Fixes https://issues.apache.org/jira/browse/CB-8750 ---- > WP8: Splashscreen should support pixel-perfect images for each resolution > ------------------------------------------------------------------------- > > Key: CB-8750 > URL: https://issues.apache.org/jira/browse/CB-8750 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin SplashScreen, WP8 > Affects Versions: 3.7.1 > Reporter: Dan Polivy > Assignee: Jesse MacFadyen > Priority: Minor > > Currently, the splashscreen plugin on Windows Phone only supports a single > SplashScreenImage.jpg file, and scales that to fit all device resolutions. > But, it is possible to detect the resolution of the device, and allow for > pixel-perfect splash screens for each individual resolution. > I have some local changes that I will send as a PR to the plugin that allows > one to specify three different images, each of different resolutions to match > those supported by WP8. > Resolution Dimensions File name > WVGA 480 x 800 SplashScreenImage.screen-WVGA.jpg > 720p 720 x 1280 SplashScreenImage.screen-720p.jpg > WXGA 768 x 1280 SplashScreenImage.screen-WXGA.jpg -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org