[ https://issues.apache.org/jira/browse/CB-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387753#comment-14387753 ]
ASF GitHub Bot commented on CB-8484: ------------------------------------ Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/164#discussion_r27446338 --- Diff: bin/templates/cordova/lib/build.js --- @@ -409,7 +457,31 @@ function parseOpts(options, resolvedTarget) { console.warn('Build option \'' + options[i] + '\' not recognized (ignoring).'); } } + if (packageArgs.keystore && packageArgs.alias) { --- End diff -- Wonding if this should actually not be exclusive with the else if clause. E.g. allow specifying buildConfig, and then also allow setting the password via --password > Cordova package support for Android > ----------------------------------- > > Key: CB-8484 > URL: https://issues.apache.org/jira/browse/CB-8484 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android > Affects Versions: 4.0.0 > Reporter: Nikhil Khandelwal > Assignee: Nikhil Khandelwal > > Details of the design here: > https://docs.google.com/document/d/1tJQ9OoGrrMhZcLI3mg46rGzAfbiQu9PuNBL1auAMGFM/edit# -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org