[ 
https://issues.apache.org/jira/browse/CB-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391019#comment-14391019
 ] 

ASF GitHub Bot commented on CB-8484:
------------------------------------

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/164#discussion_r27590209
  
    --- Diff: bin/templates/cordova/lib/build.js ---
    @@ -402,6 +440,16 @@ function parseOpts(options, resolvedTarget) {
                     case 'gradleArg':
                         ret.extraArgs.push(flagValue);
                         break;
    +                case 'keystore':
    +                case 'alias':
    +                case 'keytorePassword':
    +                case 'password':
    +                case 'keystoreType':
    +                    packageArgs[flagName] = flagValue;
    +                    break;
    +                case 'buildConfig':
    +                    buildConfig = flagValue.replace(/"/g, '');
    --- End diff --
    
    My previous statement is not true. I think I found my issue where I was 
explicitly adding quotes in cordova-lib code which was escaped by superspawn. I 
do not need this and will remove it. Thanks!


> Cordova package support for Android
> -----------------------------------
>
>                 Key: CB-8484
>                 URL: https://issues.apache.org/jira/browse/CB-8484
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Android
>    Affects Versions: 4.0.0
>            Reporter: Nikhil Khandelwal
>            Assignee: Nikhil Khandelwal
>
> Details of the design here:
> https://docs.google.com/document/d/1tJQ9OoGrrMhZcLI3mg46rGzAfbiQu9PuNBL1auAMGFM/edit#



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to