[
https://issues.apache.org/jira/browse/CB-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519989#comment-14519989
]
ASF GitHub Bot commented on CB-8870:
------------------------------------
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/47#discussion_r29370150
--- Diff: bin/medic.js ---
@@ -19,18 +19,44 @@
* under the License.
*/
-"use strict";
+/* jshint node: true */
+
+// "use strict";
// node dependencies
-var fs = require("fs");
-var os = require("os");
+var fs = require("fs");
+var os = require("os");
+var path = require("path");
// external dependencies
var shelljs = require("shelljs");
var optimist = require("optimist");
+// internal dependencies
+var testwait = require("./lib/testwait");
+var testcheck = require("./lib/testcheck");
+
// constants
-var MAX_REMOVAL_ATTEMPTS = 3;
+var MAX_REMOVAL_ATTEMPTS = 3;
+var CORDOVA_MEDIC_DIR = "cordova-medic";
+var DEFAULT_APP_PATH = "mobilespec";
+var DEFAULT_APP_ENTRY = "index.html";
+var ANDROID_TIMEOUT = 120000;
+var MEDIC_BUILD_PREFIX = "medic-cli-build";
+var DEFAULT_ENCODING = "utf-8";
+var DEFAULT_WINDOWS_VERSION = "store";
+var WINDOWS_VERSION_CHOICES = ["store", "store80", "phone"];
+var ONE_MINUTE = 1 * 60;
--- End diff --
Why 1 times 60? Time is in ms or s?
> Medic should display test failures in build status
> --------------------------------------------------
>
> Key: CB-8870
> URL: https://issues.apache.org/jira/browse/CB-8870
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Medic
> Affects Versions: Master
> Reporter: Dmitry Blotsky
> Labels: improvement, medic
> Original Estimate: 72h
> Remaining Estimate: 72h
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
