[
https://issues.apache.org/jira/browse/CB-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520120#comment-14520120
]
ASF GitHub Bot commented on CB-8870:
------------------------------------
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/47#discussion_r29375447
--- Diff: bin/medic.js ---
@@ -39,9 +65,109 @@ var argv = optimist
.argv;
// helpers
+function killTasks(taskNames) {
+
+ if (!taskNames || taskNames.length < 1) {
+ console.warn("no tasks to kill");
+ return;
+ }
+
+ if (isWindows()) {
+ var cli = "taskkill /F";
+ var args = taskNames.map(function (name) { return "/IM \"" + name
+ "\""; });
+ } else {
+ var cli = "killall";
+ var args = taskNames.map(function (name) { return "\"" + name +
"\""; });
+ }
+
+ var command = cli + " " + args.join(" ");
+ medicLog("running the following command:");
+ medicLog(" " + command);
+
+ shelljs.exec(command, {silent: false, async: true}, function
(returnCode, output) {
+ if (returnCode !== 0) {
+ console.warn("WARNING: kill command returned " + returnCode);
--- End diff --
Does it make sense to print the output also here - along with the return
code?
> Medic should display test failures in build status
> --------------------------------------------------
>
> Key: CB-8870
> URL: https://issues.apache.org/jira/browse/CB-8870
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Medic
> Affects Versions: Master
> Reporter: Dmitry Blotsky
> Labels: improvement, medic
> Original Estimate: 72h
> Remaining Estimate: 72h
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
