[ 
https://issues.apache.org/jira/browse/CB-8647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah updated CB-8647:
---------------------------------
    Component/s: CordovaLib

> `cordova platform add` should look for plugin variables first in config.xml, 
> then in fetch.json when adding a new platform
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-8647
>                 URL: https://issues.apache.org/jira/browse/CB-8647
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaLib
>            Reporter: Omar Mefire
>            Priority: Minor
>
> According to the code here : 
> https://github.com/apache/cordova-lib/blob/764c9cb12539cff50b4eaee807366c425cd1dd8a/cordova-lib/src/cordova/platform.js#L602,
> when installing a new platform, if we encounter a plugin that requires 
> variables (i.e: facebook plugin with APP_ID variable), we check in config.xml 
> for the variables to use.
> Maybe, we should check fetch.json for variables in case they aren't found in 
> config.xml. Because fetch.json would have records of currently installed 
> plugins with their variables values. Also, there might be cases when the user 
> has just installed a plugin with variables, but has not yet committed it to 
> config.xml. In this particular case, config.xml would have no variables, 
> while fetch.json would contain them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to