[
https://issues.apache.org/jira/browse/CB-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535760#comment-14535760
]
ASF GitHub Bot commented on CB-8992:
------------------------------------
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/128#discussion_r29981882
--- Diff: createmobilespec/createmobilespec.js ---
@@ -56,7 +56,8 @@ function popd(dir) {
}
function pluginAdd(pluginName, searchPath, extraFlags) {
- var command = cli + ' plugin add ' + pluginName + ' --searchpath ' +
searchPath;
+ var sp = SEARCH_PATHS.hasOwnProperty(pluginName) ?
SEARCH_PATHS[pluginName] : searchPath;
--- End diff --
It's clearer to put this logic outside of the function, on [line 568]
(https://github.com/apache/cordova-mobile-spec/pull/128/files#diff-ad19d116ad56f7b3ae8ee9fdc8733f69R568).
That way pluginAdd is only concerned with adding a plugin from a given path,
not with extra logic regarding the path.
> Mobile spec's createmobilespec always installs cordova-plugin-mobilespec-tests
> ------------------------------------------------------------------------------
>
> Key: CB-8992
> URL: https://issues.apache.org/jira/browse/CB-8992
> Project: Apache Cordova
> Issue Type: Bug
> Components: mobile-spec
> Reporter: Alexander Sorokin
> Priority: Minor
>
> Createmobilespec installs cordova-plugin-mobilespec-tests even when --plugins
> flag is present, which is used to explicitly specify list of plugins to
> install.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
