[
https://issues.apache.org/jira/browse/CB-8721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539011#comment-14539011
]
ASF GitHub Bot commented on CB-8721:
------------------------------------
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/83
CB-8721
Patch merge issues and fix failing async test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-plugin-file-transfer
CB-8721
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit 21fb03aa9c55fbd1ca4df6097b466840e91c16b8
Author: Vladimir Kotikov <v-vlk...@microsoft.com>
Date: 2015-03-24T08:19:19Z
CB-8721 Fixes incorrect headers and upload params parsing on wp8
commit 65eea291b291af2f44edb5c08c905ca66be68dd9
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date: 2015-05-09T00:23:17Z
fix merge
commit f1e41ac1f55b94e539b8e9346dfe1e6ffabb8aee
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date: 2015-05-12T00:47:08Z
fix failing test resulting from overlapping async calls
----
> (Windows Phone 8, File-transfer download method) When specifying header with
> comma in it, fail callback is called
> -----------------------------------------------------------------------------------------------------------------
>
> Key: CB-8721
> URL: https://issues.apache.org/jira/browse/CB-8721
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
> Reporter: Alexander Sorokin
> Assignee: Vladimir Kotikov
>
> This code fails because header with comma in it is not parsed properly:
> {code}
> transfer.download(fileURL, localFilePath, function win(){}, function
> fail(){}, true,
> {
> headers: {
> 'If-Modified-Since': 'Sun, 06 Nov 1994 08:49:37 GMT'
> }
> });
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
