[ https://issues.apache.org/jira/browse/CB-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590790#comment-14590790 ]
ASF GitHub Bot commented on CB-9158: ------------------------------------ Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112974712 It is a blocker typically. Modifications should be restricted to resolving the issue at hand, or at the bare minimum whitespace/formatting changes should be in their own commit. Reviewing pull requests is enough work without the overhead of having to manually sort through what is relevant. > InAppBrowser zoomControls are always set to true > ------------------------------------------------ > > Key: CB-9158 > URL: https://issues.apache.org/jira/browse/CB-9158 > Project: Apache Cordova > Issue Type: Bug > Components: Android > Affects Versions: 3.5.0 > Environment: Latest InAppBrowser > https://github.com/apache/cordova-plugin-inappbrowser, any Android device > Reporter: Anton Antonov > Labels: easyfix, patch > > InAppBrowser does not respect the passed options string to *window.open*. > *zoom=no* or *zoom=yes* will never make a difference due to source code > always assuming it's boolean true. > Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104 > P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org