[
https://issues.apache.org/jira/browse/CB-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616645#comment-14616645
]
ASF GitHub Bot commented on CB-9235:
------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/92#discussion_r34035987
--- Diff: bin/lib/check_reqs.js ---
@@ -19,15 +19,226 @@
/*jshint node:true*/
-var Q = require('Q');
+var Q = require('q');
+var os = require('os');
+var path = require('path');
+var shell = require('shelljs');
-var MSBuildTools;
+var ConfigParser, MSBuildTools, Version, exec;
try {
+ ConfigParser = require('../../template/cordova/lib/ConfigParser');
MSBuildTools = require('../../template/cordova/lib/MSBuildTools');
+ exec = require('../../template/cordova/lib/exec');
+ Version = require('../../template/cordova/lib/Version');
} catch (ex) {
// If previous import fails, we're probably running this script
// from installed platform and the module location is different.
+ ConfigParser = require('./ConfigParser');
MSBuildTools = require('./MSBuildTools');
+ exec = require('./exec');
+ Version = require('./Version');
+}
+
+// The constant for VS2013 Upd2 PackageVersion. See MSDN for
+// reference:
https://msdn.microsoft.com/en-us/library/bb164659(v=vs.120).aspx
+var VS2013_UPDATE2_RC = new Version(12, 0, 30324);
+var REQUIRED_VERSIONS = {
+ '8.0': {
+ os: '6.1',
+ msbuild: '11.0',
+ visualstudio: '11.0',
+ windowssdk: '8.0'
+ },
+ '8.1': {
+ os: '6.2',
+ msbuild: '12.0',
+ visualstudio: '12.0',
+ windowssdk: '8.1',
+ phonesdk: '8.1'
+ },
+ '10.0': {
+ os: '6.2',
--- End diff --
I've realized that there is another mistake from my side: there should be
something like:
```javascript
'8.0': {
os: '6.2', // instead of 6.1
...
},
'8.1': {
os: '6.3', // instead of 6.2
...
},
'10.0': {
os: '6.3', // Note that Windows 10 target is supported on Windows 7.
... // This case get handled in checkOS function separately
...
```
> Enhance check_reqs for Windows to include more checks
> -----------------------------------------------------
>
> Key: CB-9235
> URL: https://issues.apache.org/jira/browse/CB-9235
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Affects Versions: 4.0.0
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
>
> For Windows the requirements will vary depending on the version of Windows
> you are targeting:
> _8.1:_
> * MSBuild
> * VS 2013
> _Phone:_
> * 8.1 Phone support – at least VS 2013 Update 2.
> * Phone SDK
> _Win 10:_
> * UAP Windows SDK
> * VS 2015 RC+
> We'll need to enhance check_reqs for Windows with more checks based on the
> windows-target-version and windows-phone-target-version.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
