[ https://issues.apache.org/jira/browse/CB-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618810#comment-14618810 ]
ASF GitHub Bot commented on CB-9334: ------------------------------------ GitHub user spirann opened a pull request: https://github.com/apache/cordova-android/pull/195 CB-9334 loop on CordovaPlugins before returning remapped Uri This is a fix for https://issues.apache.org/jira/browse/CB-9334 Because sometimes you need more than one plugin to handle your Uri's. Looping on all plugins before returning the remapped Uri. You can merge this pull request into a Git repository by running: $ git pull https://github.com/spirann/cordova-android 3.7.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/195.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #195 ---- commit 2a2c8b4fbacc4707104f3f2740b1f80e1fbf8d42 Author: Simon Pireyn <spir...@gmail.com> Date: 2015-07-08T15:34:21Z CB-9334 loop on CordovaPlugins before returning remapped Uri commit f72f6cd30dbab153e33e625d2ae1d2ac04a0cc0c Author: Simon Pireyn <spir...@gmail.com> Date: 2015-07-08T15:51:57Z CB-9334 loop on CordovaPlugins before returning remapped Uri commit 3e8948650c6a42487c980b7ee396c966a9533878 Author: Simon Pireyn <spir...@gmail.com> Date: 2015-07-08T15:54:52Z Check is not bitwise ---- > PluginManager permit only one plugin to remap the URI > ----------------------------------------------------- > > Key: CB-9334 > URL: https://issues.apache.org/jira/browse/CB-9334 > Project: Apache Cordova > Issue Type: Bug > Components: Android > Affects Versions: 3.7.1 > Reporter: Simon Pireyn > Labels: android, plugins > > If a plugin return an URI and not null, the plugin manager stop calling > remapUri and use the value returned. It doesn't allow another plugin to check > or remap the URI > ex: JsHybuggerPlugin gets all URL to eventually add > "content://jsHybugger.org/" before every url. > Or if I need with one plugin to replace "myserver://" with "http://myserver" > and in another to replace {placeholders} or watherver. > PluginManager should loop every plugins before returning the remapped URI. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org