[
https://issues.apache.org/jira/browse/CB-9370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628037#comment-14628037
]
ASF GitHub Bot commented on CB-9370:
------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-js/pull/121
CB-9370 Fixes failing tests on Node 0.12 due to stale dependency
This PR fixes tests on AppVeyor, broken by updated NodeJS on CI machines as
described in [CB-9370](https://issues.apache.org/jira/browse/CB-9370). It also
adds build matrix that includes node 0.10 and 0.12 for both Travis and AppVeyor.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-js CB-9370
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-js/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
----
commit 715e2bbefc25ca9c20f476c2f5f2a906b1356c85
Author: Vladimir Kotikov <v-vlk...@microsoft.com>
Date: 2015-07-15T13:00:17Z
CB-9291 Loosens requirement for NodeJS version
commit 55003223d23dbf1dd20fa5c21a70c9d0fdf96db3
Author: Vladimir Kotikov <v-vlk...@microsoft.com>
Date: 2015-07-15T13:05:21Z
CB-9370 Fixes failing tests on Node 0.12 due to stale dependency
This also adds Node@0.12 to test matrix for both Travis and AppVeyor
----
> Cordova-js tests are failing on node 0.12
> -----------------------------------------
>
> Key: CB-9370
> URL: https://issues.apache.org/jira/browse/CB-9370
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaJS
> Affects Versions: 4.1.0
> Environment: Windows/Mac OSX machine,
> Node JS 0.12.7
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
> Labels: cordova-js
> Fix For: 4.1.0
>
>
> Since https://github.com/apache/cordova-js/pull/118 unit tests for cordova-js
> started failing on AppVeyor CI with unclear message {{Fatal error: Cannot set
> property length of [object Object] which has only a getter}}.
> It looks like the origin of failures - updated NodeJS version on AppVeyor
> build machines. Failure also can be reproduced on local machine with
> Node@0.12.5 installed.
> The reason of failures - is outdated {{jsdom-nogyp}} dependency (last updated
> about 2 years ago). The solution is to replace {{jsdom-nogyp}} with original
> {{node-jsdom}}, which works fine with node@12.x. It also would be great to
> test such cases through CI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
