[ https://issues.apache.org/jira/browse/CB-9426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646143#comment-14646143 ]
ASF GitHub Bot commented on CB-9426: ------------------------------------ Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125975741 Yeah. I was still going to look at a rewrite in the near future. No need to fake data... > On Jul 29, 2015, at 6:38 AM, Vladimir Kotikov <notificati...@github.com> wrote: > > The PR LGTM. > > However, IMO the code that emits devicemotion events might be removed due to: > a) this is not a scope of plugin to provide stubs for browser functionality > b) the devicemotion event is already supported by most of the browsers (http://caniuse.com/#search=devicemotion). > > @purplecabbage, what do you think? > > — > Reply to this email directly or view it on GitHub. > > Exception using device motion plugin on browser platform > -------------------------------------------------------- > > Key: CB-9426 > URL: https://issues.apache.org/jira/browse/CB-9426 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Device Motion > Reporter: Tim Barham > Assignee: Tim Barham > Original Estimate: 4h > Remaining Estimate: 4h > > When you use the {{device motion}} plugin on the browser platform, you get > the following exception: > {{module cordova-plugin-device-motion.accelerometer already defined}} > This is because the {{accelerometer}} module name is used twice in plugin.xml. > Note that exactly the same problem exists for the {{device orientation}} > plugin. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org