[ https://issues.apache.org/jira/browse/CB-9496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698903#comment-14698903 ]
ASF GitHub Bot commented on CB-9496: ------------------------------------ GitHub user devgeeks opened a pull request: https://github.com/apache/cordova-android/pull/206 CB-9496 removed permissions added for crosswalk These would better live in the actual crosswalk plugin https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview I have also submitted a PR to that repo adding them to its `plugin.xml` https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview/pull/43 You can merge this pull request into a Git repository by running: $ git pull https://github.com/devgeeks/cordova-android CB-9496 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/206.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #206 ---- commit 042702017a1de93a164bd0701786d7e88115064f Author: Tommy-Carlos Williams <to...@devgeeks.org> Date: 2015-08-17T00:17:29Z CB-9496 removed permissions added for crosswalk These would better live in the actual crosswalk plugin https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview I will also submit a PR to that repo adding them to its `plugin.xml` ---- > Spurious permissions added to Android platform > ---------------------------------------------- > > Key: CB-9496 > URL: https://issues.apache.org/jira/browse/CB-9496 > Project: Apache Cordova > Issue Type: Bug > Components: Android > Reporter: Tommy-Carlos Williams > > These two permissions: > {{<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />}} > {{<uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />}} > Were added to support something in Crosswalk, but they really should be in > the Crosswalk plugin if that is what needs them. They are now being added to > *every* Android platform needed or not. > https://github.com/apache/cordova-android/commit/4a67dd2e28aed257c85b75c11026ae7a2a19c2ad -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org