[ 
https://issues.apache.org/jira/browse/CB-9370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718182#comment-14718182
 ] 

Vladimir Kotikov edited comment on CB-9370 at 8/28/15 8:09 AM:
---------------------------------------------------------------

Switching to {{node-jsdom}} was a mistake due to fact that it requires too many 
things to set up first (Visual Studio/Python).

This causes multiple problems for devs and unpredictable test failures on our 
Windows CI. See 
https://ci.appveyor.com/project/Humbedooh/cordova-lib/build/1.0.911

{{jsdom-nogyp}} dependency was introduced as a replacement for original 
{{jsdom}} by the same reason. See 
https://issues.apache.org/jira/browse/CB-5438. Need to find another alternative.


was (Author: vladimir.kotikov):
Switching to {{node-jsdom}} was a mistake due to fact that it requires too many 
things to set up first (Visual Studio/Python).

This causes multiple problems for devs and unpredictable test failures on our 
Windows CI. See 
https://ci.appveyor.com/project/Humbedooh/cordova-lib/build/1.0.911

> Cordova-js tests are failing on node 0.12
> -----------------------------------------
>
>                 Key: CB-9370
>                 URL: https://issues.apache.org/jira/browse/CB-9370
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaJS
>    Affects Versions: 4.1.0
>         Environment: Windows/Mac OSX machine,
> Node JS 0.12.7
>            Reporter: Vladimir Kotikov
>            Assignee: Vladimir Kotikov
>              Labels: cordova-js
>             Fix For: 4.1.0
>
>
> Since https://github.com/apache/cordova-js/pull/118 unit tests for cordova-js 
> started failing on AppVeyor CI with unclear message {{Fatal error: Cannot set 
> property length of [object Object] which has only a getter}}.
> It looks like the origin of failures - updated NodeJS version on AppVeyor 
> build machines. Failure also can be reproduced on local machine with 
> Node@0.12.5 installed.
> The reason of failures - is outdated {{jsdom-nogyp}} dependency (last updated 
> about 2 years ago). The solution is to replace {{jsdom-nogyp}} with original 
> {{node-jsdom}}, which works fine with node@12.x. It also would be great to 
> test such cases through CI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to