[
https://issues.apache.org/jira/browse/CB-9589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943078#comment-14943078
]
ASF GitHub Bot commented on CB-9589:
------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/313#discussion_r41121721
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -404,6 +418,20 @@ function installDependencies(install, dependencies,
options) {
return dependencies.reduce(function(soFar, dep) {
return soFar.then(
function() {
+ // Split @Version from the plugin id if it exists.
+ var splitVersion = dep.id.split('@');
+ //Check if a mapping exists for the plugin id
+ //if it does, convert id to new name id
+ var newId = pluginMapper[splitVersion[0]];
+ if(newId) {
+ events.emit('log', 'Notice: ' + dep.id + ' has been
automatically converted to ' + newId + ' and fetched from npm. This is due to
our old plugins registry shutting down.');
--- End diff --
Shouldn't this be emitted with `warn` level to encourage users to switch to
new plugin id instead of relying on plugin mapper?
> convert old plugin IDs to new plugin IDs using registry-mapper
> --------------------------------------------------------------
>
> Key: CB-9589
> URL: https://issues.apache.org/jira/browse/CB-9589
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaLib
> Reporter: Steve Gill
> Assignee: Steve Gill
> Fix For: 5.4.0
>
>
> Right now, cordova-lib will warn developers to use the new plugin id. We want
> to auto switch the idea to the new one and fetch from npm.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
