[
https://issues.apache.org/jira/browse/CB-9739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944132#comment-14944132
]
ASF GitHub Bot commented on CB-9739:
------------------------------------
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/95#discussion_r41204416
--- Diff: src/create-verify-archive.js ---
@@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
var absOutDir = path.resolve(outDir);
yield repoutil.forEachRepo(repos, function*(repo) {
+ if(isWin) {
--- End diff --
Thanks for the clarification @daserge
On Mac by default using git from XCode Tools, both of the settings
core.autocrlf and core.eol are not set at all, so I would think let's leave
this check only for Win as you have it here, go ahead and merge this PR
> Prevent coho from creating broken packages including CRLF on Windows
> --------------------------------------------------------------------
>
> Key: CB-9739
> URL: https://issues.apache.org/jira/browse/CB-9739
> Project: Apache Cordova
> Issue Type: Bug
> Components: Coho
> Environment: Windows
> Reporter: Sergey Shakhnazarov
> Assignee: Sergey Shakhnazarov
>
> {code}git config --get core.autocrlf{code} is *true* by default on Windows,
> which causes line endings to be converted to CRLF on clone so that further
> create-archive embeds CRLFs into all files including shell scripts -> this
> causes failures on Unix systems.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
