[ 
https://issues.apache.org/jira/browse/CB-9784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954497#comment-14954497
 ] 

ASF GitHub Bot commented on CB-9784:
------------------------------------

Github user daserge commented on the pull request:

    https://github.com/apache/cordova-cli/pull/224#issuecomment-147620672
  
    > We should remove this: 
https://github.com/apache/cordova-cli/pull/224/files#diff-567859a4cc8b910de0454da79959bde6R53
 - I know a lot of downstream tools currently use Error: prefix to determine 
something is an error vs not.
    
    It makes sense in terms of backwards compatibility - removed this trimming. 
    Although we will need to revert those code where we have removed the 
`Error: ` prefixes or alternatively concat such a prefix automatically in 
logger for `error` level if it is missing in an event message.
    
    In this case we will still have an excess noise but it should be acceptable 
as error messages are uncommon.
    
    What do you think?


> Remove CLI logger levels prefixes
> ---------------------------------
>
>                 Key: CB-9784
>                 URL: https://issues.apache.org/jira/browse/CB-9784
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>            Reporter: Sergey Shakhnazarov
>            Assignee: Sergey Shakhnazarov
>
> EventEmitter usage provides info on an event level so the prefixing may be 
> superfluous taking into account we have coloring distinction for event levels.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to