[
https://issues.apache.org/jira/browse/CB-9590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960863#comment-14960863
]
ASF GitHub Bot commented on CB-9590:
------------------------------------
Github user david-barth-canonical commented on the pull request:
https://github.com/apache/cordova-lib/pull/294#issuecomment-148743166
ok, i understand the problem now. In particular, the code to guess the
classname is nice, but other platforms resort to encapsulating this
information into the plugin.xml file which is safer.
We have some new code in cordova-ubuntu to handle dependencies, so I wonder
how much of that logic needs to be updated in cordova-lib, rather than
directly in cordova-ubuntu? See mardy's new branch
https://github.com/mardy/cordova-ubuntu/commit/d3a674f2a07ab269bfb2e2acaa60dc2ab25c4d50
On Thu, Oct 15, 2015 at 6:26 PM, Tim Barham <notificati...@github.com>
wrote:
> @david-barth-canonical <https://github.com/david-barth-canonical> - I
> think @stevengill <https://github.com/stevengill>'s point is that the
> intent of your change is to strip the cordova-plugin from the start of
> the plugin name to generate the class name, to get the equivalent of the
> old functionality. That logic won't work with plugins that don't start
with
> cordova-plugin-. Perhaps an alternative would be to look for -plugin- in
> the name, and take everything after that (?otherwise just use the whole
> name).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-lib/pull/294#issuecomment-148444797>.
>
> install header-files breaks with new naming convention on ubuntu
> ----------------------------------------------------------------
>
> Key: CB-9590
> URL: https://issues.apache.org/jira/browse/CB-9590
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Reporter: David Barth
>
> Trying to install a plugin using the new naming convention breaks on the
> current ubuntu version.
> cordova plugin add cordova-plugin-console
> Fetching plugin "cordova-plugin-console" via npm
> npm http GET https://registry.npmjs.org/cordova-plugin-console
> npm http 304 https://registry.npmjs.org/cordova-plugin-console
> Installing "cordova-plugin-console" for ubuntu
> Error during processing of action! Attempting to revert...
> Failed to install 'cordova-plugin-console':TypeError: Uh oh!
> Cannot read property '0' of null
> at Object.module.exports.header-file.install
> (/usr/share/cordova-cli/node_modules/cordova-lib/src/plugman/platforms/ubuntu.js:74:57)
> at installWrapper
> (/usr/share/cordova-cli/node_modules/cordova-lib/src/platforms/platforms.js:76:32)
> at Object.ActionStack.process
> (/usr/share/cordova-cli/node_modules/cordova-lib/src/plugman/util/action-stack.js:68:25)
> at handleInstall
> (/usr/share/cordova-cli/node_modules/cordova-lib/src/plugman/install.js:543:20)
> at
> /usr/share/cordova-cli/node_modules/cordova-lib/src/plugman/install.js:335:28
> at _fulfilled (/usr/share/cordova-cli/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/usr/share/cordova-cli/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/usr/share/cordova-cli/node_modules/q/q.js:749:13)
> at /usr/share/cordova-cli/node_modules/q/q.js:509:49
> at flush (/usr/share/cordova-cli/node_modules/q/q.js:108:17)
> TypeError: Uh oh!
> Cannot read property '0' of null
> at Object.module.exports.header-file.install
> (/usr/share/cordova-cli/node_modules/cordova-lib/src/plugman/platforms/ubuntu.js:74:57)
> at installWrapper
> (/usr/share/cordova-cli/node_modules/cordova-lib/src/platforms/platforms.js:76:32)
> at Object.ActionStack.process
> (/usr/share/cordova-cli/node_modules/cordova-lib/src/plugman/util/action-stack.js:68:25)
> at handleInstall
> (/usr/share/cordova-cli/node_modules/cordova-lib/src/plugman/install.js:543:20)
> at
> /usr/share/cordova-cli/node_modules/cordova-lib/src/plugman/install.js:335:28
> at _fulfilled (/usr/share/cordova-cli/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/usr/share/cordova-cli/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/usr/share/cordova-cli/node_modules/q/q.js:749:13)
> at /usr/share/cordova-cli/node_modules/q/q.js:509:49
> at flush (/usr/share/cordova-cli/node_modules/q/q.js:108:17)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
