[
https://issues.apache.org/jira/browse/CB-9834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976444#comment-14976444
]
ASF GitHub Bot commented on CB-9834:
------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/329
CB-9834 Introduce cordova modules compatibility map for plugin hooks
This fixes potential issue with third-party plugin hooks, since many of
them using internal cordova modules, in particular `ConfigParser` and
`xml-helpers`.
The sample case is desribed in
[CB-9834](https://issues.apache.org/jira/browse/CB-9834)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-9834
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/329.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #329
----
commit 7e10c4abcb699b2ea7ce5ec5f4c2c53482ef8523
Author: Vladimir Kotikov <v-vlk...@microsoft.com>
Date: 2015-10-27T12:20:10Z
CB-9834 Introduce compat map for hook requires
----
> Hooks in crosswalk plugin do not work any more because we moved ConfigParser
> ----------------------------------------------------------------------------
>
> Key: CB-9834
> URL: https://issues.apache.org/jira/browse/CB-9834
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Affects Versions: Master
> Reporter: Nikhil Khandelwal
> Assignee: Vladimir Kotikov
> Priority: Critical
>
> Get the master version of cordova-lib and cordova-cli and create a cordova
> project.
> Add the cross-walk plugin: cordova plugin add cordova-plugin-crosswalk-webview
> Fetching plugin "cordova-plugin-crosswalk-webview@^1.2.0" via npm
> Installing "cordova-plugin-crosswalk-webview" for android
> Failed to install 'cordova-plugin-crosswalk-webview':Error: Cannot find
> module 'cordova-lib/src/configparser/ConfigParser'
> at Function.Module._resolveFilename (module.js:336:15)
> at Function.Module._load (module.js:286:25)
> at Module.require (module.js:365:17)
> at require (module.js:384:17)
> at Context.requireCordovaModule
> (D:\cordova\cordova-lib\cordova-lib\src\hooks\Context.js:48:12)
> at module.exports
> (d:\apps\test\plugins\cordova-plugin-crosswalk-webview\hooks\after_plugin_install\000-shared_mode_special.js:9:32)
> at runScriptViaModuleLoader
> (D:\cordova\cordova-lib\cordova-lib\src\hooks\HooksRunner.js:151:18)
> at runScript
> (D:\cordova\cordova-lib\cordova-lib\src\hooks\HooksRunner.js:129:16)
> at D:\cordova\cordova-lib\cordova-lib\src\hooks\HooksRunner.js:114:20
> at _fulfilled
> (D:\cordova\cordova-lib\cordova-lib\node_modules\q\q.js:787:54)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
