[ https://issues.apache.org/jira/browse/CB-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977319#comment-14977319 ]
ASF GitHub Bot commented on CB-9274: ------------------------------------ Github user paulhovey commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/107#issuecomment-151667555 I agree completely with @dennisexozet . +1 Thanks! > InAppBrowser compile error for Amazon FireOS > -------------------------------------------- > > Key: CB-9274 > URL: https://issues.apache.org/jira/browse/CB-9274 > Project: Apache Cordova > Issue Type: Bug > Components: Amazon FireOS, Plugin InAppBrowser > Affects Versions: 3.5.0 > Reporter: Ian Paterson > Assignee: Archana Naik > Labels: compile-error, patch > > Attempting to compile the InAppBrowser plugin for Amazon FireOS fails due to > the following programming errors: > {noformat} > [javac] Compiling 8 source files to > /path/to/amazon-fireos/ant-build/classes > [javac] > /path/to/amazon-fireos/src/org/apache/cordova/inappbrowser/InAppBrowserDialog.java:51: > cannot find symbol > [javac] symbol : method hardwareBack() > [javac] location: class org.apache.cordova.inappbrowser.InAppBrowser > [javac] if (this.inAppBrowser.hardwareBack() && > this.inAppBrowser.canGoBack()) { > [javac] ^ > [javac] > /path/to/amazon-fireos/src/org/apache/cordova/inappbrowser/InAppBrowserDialog.java:51: > cannot find symbol > [javac] symbol : method canGoBack() > [javac] location: class org.apache.cordova.inappbrowser.InAppBrowser > [javac] if (this.inAppBrowser.hardwareBack() && > this.inAppBrowser.canGoBack()) { > [javac] > ^ > [javac] > /path/to/amazon-fireos/src/org/apache/cordova/inappbrowser/InAppBrowserDialog.java:52: > goBack() has private access in org.apache.cordova.inappbrowser.InAppBrowser > [javac] this.inAppBrowser.goBack(); > [javac] ^ > [javac] Note: > /path/to/amazon-fireos/src/org/apache/cordova/inappbrowser/InAppBrowser.java > uses or overrides a deprecated API. > [javac] Note: Recompile with -Xlint:deprecation for details. > [javac] 3 errors > {noformat} > As best I can determine, this problem has existed since plugin version 0.5.2 > and was introduced on August 14 in [commit > 69ca780772b406ab02ec1bd1a8e4dca70052e926|https://github.com/apache/cordova-plugin-inappbrowser/commit/69ca780772b406ab02ec1bd1a8e4dca70052e926]. > Previous commits had diverged the implementation of InAppBrowser.java in > Amazon FireOS such that it was no longer compatible with the > InAppBrowser.java for Android. > I am preparing a pull request to patch this issue to restore the ability to > use the plugin on this platform. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org