[ 
https://issues.apache.org/jira/browse/CB-9919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992657#comment-14992657
 ] 

Richard B Knoll edited comment on CB-9919 at 11/5/15 10:58 PM:
---------------------------------------------------------------

Thanks for working on this. I did all of the above: Pulled from master, ran npm 
install, and set my global and local configs to reflect the line ending 
settings you mentioned (I verified these using --list before committing). Upon 
commit I get 9 insertions and 96 deletions for a single line of code changed, 
so something beyond CRLF issues is clearly taking place. Can we remove the 
pre-commit hook?


was (Author: riknoll):
Thanks for working on this. I did all of the above: Pulled from master, ran npm 
install, and set my global and local configs to reflect the line ending 
settings you mentioned (I verified these using --lsit before committing). Upon 
commit I get 9 insertions and 96 deletions for a single line of code changed, 
so something beyond CRLF issues is clearly taking place. Can we remove the 
pre-commit hook?

> Docs gen uses Windows line endings on Windows
> ---------------------------------------------
>
>                 Key: CB-9919
>                 URL: https://issues.apache.org/jira/browse/CB-9919
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Camera
>         Environment: Windows 10
>            Reporter: Richard B Knoll
>
> The new precommit hook that generates the docs in the camera repo uses the 
> line endings of the environment you're developing in. This means that 
> whenever I commit in in Windows, it tries to commit a huge diff in the README 
> because it changes all of the line endings



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to