[
https://issues.apache.org/jira/browse/CB-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998402#comment-14998402
]
ASF GitHub Bot commented on CB-9831:
------------------------------------
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/238#issuecomment-155388076
LGTM.
IMO it might be better to use promises in `projectActions` to reduce
'pyramids of doom' in
[update.spec.js](https://github.com/apache/cordova-android/pull/238/files#diff-0f89b7fec99ccbdee182426eae6f10cdR34)
but this is a matter of taste
> cordova-android's 'test-build' script removes the contents of symlinked
> cordova-common directory
> ------------------------------------------------------------------------------------------------
>
> Key: CB-9831
> URL: https://issues.apache.org/jira/browse/CB-9831
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: Master
> Reporter: Alexander Sorokin
> Assignee: Alexander Sorokin
>
> when cordova-common directory is symlinked by coho, cordova-android's
> 'test-build' script removes all its contents
> Windows repro:
> {noformat}
> cordova-coho\coho npm-link
> cd cordova-android
> npm run test-build
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
