[ 
https://issues.apache.org/jira/browse/CB-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069615#comment-15069615
 ] 

ASF GitHub Bot commented on CB-10233:
-------------------------------------

Github user mirkoluchi commented on the pull request:

    https://github.com/apache/cordova-ios/pull/186#issuecomment-166891897
  
    Hi, I added some tests to assert that the correct config file is loaded.
    If you this other regression tests are needed, please tell me and I'll try 
to figure out how to do that.


> Support different config.xml file per CDVViewController instance
> ----------------------------------------------------------------
>
>                 Key: CB-10233
>                 URL: https://issues.apache.org/jira/browse/CB-10233
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: iOS
>    Affects Versions: Master
>            Reporter: Mirko Luchi
>            Priority: Minor
>              Labels: cordova-ios-4.1.0
>
> CDVViewController strongly assumes that cordova configuration is in a 
> config.xml file in the application's main bundle.
> This approach has several drawbacks:
> - each instance of CDVViewController have a single shared configuration file 
> (which is not always desireable)
> - configuration file cannot be placed in custom locations (e.g. a bundle of a 
> library containing a reusable subclass of CDVViewController loading a custom 
> HTML page).
> Cordova setting file path should be configurable through a property on the 
> CDVViewController class, and settings loading should be delayed in the 
> viewDidLoad method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to