[
https://issues.apache.org/jira/browse/CB-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111697#comment-15111697
]
ASF GitHub Bot commented on CB-10405:
-------------------------------------
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/72#discussion_r50489033
--- Diff: medic/medic-run.js ---
@@ -324,23 +349,8 @@ function main() {
util.fatal("app " + appPath + " does not exist");
}
- util.medicLog("checking if " + couchdbURI + " is up");
-
- // check if results server is up
- request({
- uri: couchdbURI,
- method: "GET",
- timeout: SERVER_RESPONSE_TIMEOUT
- },
- function (error, response, body) {
-
- // bail if the results server is down
- if (error || response.statusCode !== 200) {
- util.fatal("it's not up, so test run can't be monitored");
- process.exit(1);
- } else {
- util.medicLog("it's up");
- }
+ onConnect(couchdbURI, 1, function(){
--- End diff --
If possible, maybe also change the signature of the retry function to hide
the `1` from the caller, so that it only takes a URI and a callback.
> Connectivity issue to Cordova VM
> ---------------------------------
>
> Key: CB-10405
> URL: https://issues.apache.org/jira/browse/CB-10405
> Project: Apache Cordova
> Issue Type: Bug
> Reporter: Sarangan Rajamanickam
> Assignee: Sarangan Rajamanickam
> Labels: found-by-ci
>
> During Apache Cordova CI, we get errors while checking the cordova VMs. They
> are intermittent. So, we need to add retry logic to the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
