[
https://issues.apache.org/jira/browse/CB-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118499#comment-15118499
]
ASF GitHub Bot commented on CB-10440:
-------------------------------------
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/142#discussion_r50934617
--- Diff: template/cordova/lib/AppxManifest.js ---
@@ -374,6 +374,11 @@ AppxManifest.prototype.getCapabilities = function () {
};
function refineColor(color) {
+ if (color.indexOf('0x') === -1 && color.indexOf('#') === -1) {
--- End diff --
Is there a list of valid CSS colours? For example, `meow` and `12345` and
are not colours, but they will get accepted here.
> Add CSS color names support for BackgroundColor on Windows
> ----------------------------------------------------------
>
> Key: CB-10440
> URL: https://issues.apache.org/jira/browse/CB-10440
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Windows
> Reporter: Sergey Shakhnazarov
> Assignee: Sergey Shakhnazarov
>
> 1. Create a new Cordova project
> 2. Open config.xml
> 3. Add <preference name="BackgroundColor" value="transparent"/> to the file.
> 4. Build for Windows platform
> Actual:
> APPX3037
> App manifest validation failed. Value '#transparent' of attribute
> '/Package/Applications/Application/m3:VisualElements/@BackgroundColor' is not
> a valid color name or color hexadecimal identifier.
>
> This is because the generated appmanifest has this line :
> <uap:VisualElements BackgroundColor="#transparent" ... />
> where it doesn't expect the value to be a named color value other than a
> hexadecimal color value.
> Expected:
> The appmanifest file can be generated correctly, with a value like:
> <uap:VisualElements BackgroundColor="transparent" ... />
> or
> <uap:VisualElements BackgroundColor="turquoise" ... />
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
