[ https://issues.apache.org/jira/browse/CB-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121256#comment-15121256 ]
ASF GitHub Bot commented on CB-10303: ------------------------------------- GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/145 CB-10303 Add tests to cover arguments parsing regression You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-windows CB-10303 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/145.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #145 ---- commit ecb57e6ee6802a2650e550919692680e0101c8f6 Author: Vladimir Kotikov <kotikov.vladi...@gmail.com> Date: 2016-01-28T10:53:20Z Refactor tests: Use jamine spies instead of rewire in most cases Do not stub console log to simplify debug commit 03324a000164c2a07dcf00acca19d97867c09124 Author: Vladimir Kotikov <kotikov.vladi...@gmail.com> Date: 2016-01-28T11:36:51Z CB-10303 Adds tests to cover arguments parsing regression ---- > Windows platform ignores some build options > ------------------------------------------- > > Key: CB-10303 > URL: https://issues.apache.org/jira/browse/CB-10303 > Project: Apache Cordova > Issue Type: Bug > Components: Windows > Affects Versions: 4.3.0 > Reporter: Vladimir Kotikov > Assignee: Vladimir Kotikov > Priority: Critical > Fix For: 4.3.0 > > > When we run packaging, we put values in the build.json file like this: > {code:title=build.json} > { > "windows": { > "release": { > "packageCertificateKeyFile": "res\\native\\windows\\CordovaApp.pfx", > "publisherId": "CN=995C8641-FD13-454D-B93F-C1E4381956B9" > } > } > } > {code} > After the packaging, the appxmanifest file has this in it: {{<Identity ... > Publisher="CN=$username$" Version="1.1.0.0" />}} > The {{$username$}} should have been replaced by > CN=995C8641-FD13-454D-B93F-C1E4381956B9. > Another problem, related to arguments parsing is that build.js ignores > {{options.archs}} and take it if I set {{options.argv='--archs=x64'}} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org