[ https://issues.apache.org/jira/browse/CB-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126068#comment-15126068 ]
ASF subversion and git services commented on CB-10394: ------------------------------------------------------ Commit 188ac247a88aaaa82352f4265f2f0c8e08e8d1f2 in cordova-windows's branch refs/heads/4.3.x from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=188ac24 ] CB-10394 Do not cache manifest file while getting package name > config-file changes are not written to package.windows.appxmanifest > ------------------------------------------------------------------- > > Key: CB-10394 > URL: https://issues.apache.org/jira/browse/CB-10394 > Project: Apache Cordova > Issue Type: Bug > Components: Windows > Affects Versions: 4.3.0 > Reporter: Marco Biasini > Assignee: Vladimir Kotikov > Labels: regression, triaged > > I've noticed that config-file changes defined in a plugin are not correctly > written to package.windows.appxmanifest file. After a plugin import, the file > does not contain these changes. The changes are correctly applied to the > other appxmanifest files (phone, windows10, windows80). > I've bested both with windows platform 4.3.0 as well as master and the > problem exists in both branches. > The problem is related to the appxmanifest caching mechanism. The > package.windows.appxmanifest file is loaded early on to determine the package > name (through jsprojManager.getPackageName()). The appxmanifest content is > then cached in memory. Then, the config-file changes defined in the > plugin.xml file are applied to the manifests and written to disk. They do not > use the cached manifests from the earlier step,but rather load the files > through a different code path. After that all previously cached appxmanifest > instances are then written to disk, which effectively overwrites the content > of package.windows.appxmanifest. Since this is the only manifest that gets > loaded early on, this does not affect the other appxmanifest files. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org