[
https://issues.apache.org/jira/browse/CB-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130435#comment-15130435
]
ASF GitHub Bot commented on CB-10465:
-------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/374
CB-10465 Pass correct options to prepare from compile
This fixes incorrect behaviour of `cordova emulate` command, which results
in restoring all saved platforms even when only particular platform specified.
See [CB-10465](https://issues.apache.org/jira/browse/CB-10465) for details
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-10465
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/374.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #374
----
commit ff89da1de181f870c2461b1502d207a668c9b648
Author: Vladimir Kotikov <v-vlk...@microsoft.com>
Date: 2016-02-03T13:55:31Z
CB-10465 Pass correct options to prepare from compile
----
> cordova.raw.emulate fires a cordova.raw.prepare with incorrect arguments
> ------------------------------------------------------------------------
>
> Key: CB-10465
> URL: https://issues.apache.org/jira/browse/CB-10465
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Affects Versions: 5.4.1
> Reporter: Manuel Martiarena
> Assignee: Vladimir Kotikov
> Labels: cordova-lib, regression, triaged
>
> All cordova.raw command now need to be called with arguments like this ticket
> expains: https://issues.apache.org/jira/browse/CB-9987.
> Unfortunately the raw emulate command executes the raw prepare with the wrong
> structure of arguments, with the side effect that if you want to emulate only
> iOS, the other configured projects will also be add/checked/prepared.
> emulate.js calls it like this:
> return require('./cordova').raw.prepare(options.platforms);
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/emulate.js
> line 36
> But the argument should be an object with a key named platforms. like so:
> return require('./cordova').raw.prepare({platforms: options.platforms});
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
